Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33379 )
Change subject: soc/intel: Provide SPD manufacturer ID and module type to SMBIOS ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/33379/1/src/soc/intel/apollolake/meminit_uti... File src/soc/intel/apollolake/meminit_util_apl.c:
https://review.coreboot.org/#/c/33379/1/src/soc/intel/apollolake/meminit_uti... PS1, Line 98: 0);
Why only APL didn't pass the type? Only support one type?
APL FSP does not expose the SpdModuleType.
https://review.coreboot.org/#/c/33379/1/src/soc/intel/common/smbios.c File src/soc/intel/common/smbios.c:
https://review.coreboot.org/#/c/33379/1/src/soc/intel/common/smbios.c@31 PS1, Line 31: mod_type
You use ddr3 defines to convert ddr4 mod_type to DDR2? […]
This was re-used from elsewhere in the codebase as a stop-gap as reworking the smbios properly is a bit more of a change than I have time for this week.
https://review.coreboot.org/#/c/33379/1/src/soc/intel/common/smbios.c@29 PS1, Line 29: dimm->mod_id = mod_id; : /* Translate to DDR2 module type field that SMBIOS code expects. */ : switch (mod_type) { : case SPD_DIMM_TYPE_SO_DIMM: : dimm->mod_type = SPD_SODIMM; : break; : case SPD_DIMM_TYPE_72B_SO_CDIMM: : dimm->mod_type = SPD_72B_SO_CDIMM; : break; : case SPD_DIMM_TYPE_72B_SO_RDIMM: : dimm->mod_type = SPD_72B_SO_RDIMM; : break; : case SPD_DIMM_TYPE_UDIMM: : dimm->mod_type = SPD_UDIMM; : break; : case SPD_DIMM_TYPE_RDIMM: : dimm->mod_type = SPD_RDIMM; : break; : case SPD_DIMM_TYPE_UNDEFINED: : default: : dimm->mod_type = SPD_UNDEFINED; : break; : }
why it is not inhere: src/arch/x86/smbios.c for exmple ? […]
smbios only expects DDR2 SPD type and is not compatible with ddr3/4