Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34948 )
Change subject: superio: nuvoton: add a driver for nct668xd
......................................................................
Patch Set 4:
(2 comments)
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34948/4/src/superio/nuvoton/common/...
File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/34948/4/src/superio/nuvoton/common/...
PS4, Line 76:
:
:
don't remove the support for the nct6791 here
ouch.... it was late.....
https://review.coreboot.org/c/coreboot/+/34948/4/src/superio/nuvoton/common/...
PS4, Line 90: tmp
u8 tmp
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34948
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78eca4ba2948c36a386306887f62773580f6e444
Gerrit-Change-Number: 34948
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Sep 2019 05:45:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment