Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46275 )
Change subject: cpu/intel/common: rework AES-NI locking
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46275/7/src/cpu/intel/common/common...
File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/46275/7/src/cpu/intel/common/common...
PS7, Line 281: /* Check if already locked */
Isn't that literally repeating the code? It's exactly the kind of comment […]
ack, since it's now pretty clear what the code does
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46275
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2cda433bbec0192277839c02a1862b8f41340cb
Gerrit-Change-Number: 46275
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 17 Oct 2020 13:32:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment