Joseph Samuel Pacheco-Corwin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30904 )
Change subject: Revert "vboot: Fix linking error with USE_OPTION_TABLE enabled" ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
Thinkpad xx20 series usb_always_on. Replying at the request of Hellsenberg.
Apologies, can confirm that this fixes the broken USB_ALWAYS_ON option on Thinkpad xx20. Confirmed with a T420 and T520.
Please post the commit hash and console log. The question is if the new (non SMM) method is affected, or the old (SMM) method is.
Sorry it took so long, here's a paste of the CBMEM log of both Master and the Revert
Master: https://paste.ee/p/pd1kG Revert: https://paste.ee/p/9JcpM
I wasn't able prevent the log from being truncated, sorry. Both are around 68KB, so I hope this helps.
Great ! Both logs show that the cmos_layout.bin can be located using the different methods. Please explain why this change is necessary, as the log(s) doesn't show any issue.
This revert has show to fix an issue with usb_always_on with xx20 ThinkPads. Power was not being supplied to any USB port, despite having usb_always_on enabled in nvramcui, set to AC and Battery. This was tested with two ThinkPads, a T520 and T420. Neither dedicated Always On ports worked during both both Laptop suspend and powered down while plugged into AC, unlike the stock bios. With this reversion, functionality was restored, but as I don't understand the inner working of coreboot yet, I cannot tell you exactly why this is happening. I'm sorry I'm not able to provide more than this.