[coreboot-gerrit] Change in ...coreboot[master]: Makefile.inc: Compile smm files based on CONFIG_BUILD_SMM

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33115 )

Change subject: Makefile.inc: Compile smm files based on CONFIG_BUILD_SMM
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/33115/5/src/arch/x86/Makefile.inc 
File src/arch/x86/Makefile.inc:

https://review.coreboot.org/#/c/33115/5/src/arch/x86/Makefile.inc@403 
PS5, Line 403: CONFIG_BUILD_SMM
> isn't the case that we need to compile smm code for x86 platform ? […]

I'm saying that moving these stanzas here is required. But I'm not convinced we need to find all the places and guard the blocks. I'm suggesting removing the root dependency removes the need for doing per-Makefile guarding of these recipes. I want to focus on removing the root dependency when these options aren't selected.