Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31051 )
Change subject: mb/{kontron,supermicro}: Use pcidev_on_root() ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31051/2/src/mainboard/supermicro/h8scm_fam10... File src/mainboard/supermicro/h8scm_fam10/mptable.c:
https://review.coreboot.org/#/c/31051/2/src/mainboard/supermicro/h8scm_fam10... PS2, Line 48: pirq_router_bus TODO: why bus_sp5100[0] use same value of : * bus_sr5650[0] assigned by get_pci1234(), instead of 0. This comment is more confusing after the reformatting. I'm not too familiar with the AMD code, but maybe it's better placed near line 44 of h8scm_fam10/get_bus_conf.c