[coreboot-gerrit] Change in coreboot[master]: Revert "security/intel/stm: Add STM support"

[Name of user not set (Code Review)]

[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38322 )

Change subject: Revert "security/intel/stm: Add STM support"
......................................................................

Patch Set 1:

(2 comments)

A little surprising unless the fields that are in smm_stub.S are accessed by a different data structure than smm_runtime.
I would use Patrick's suggestion in mp_init.c and move the align to the STM setup code above to take out that possibility.

As I noted before, I would like to see the trace.

I am away from work, so it will take a couple hours before I can get to work to issue a fix.

https://review.coreboot.org/c/coreboot/+/38322/1/src/cpu/x86/mp_init.c 
File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/38322/1/src/cpu/x86/mp_init.c@a1056 
PS1, Line 1056: 	state->smm_save_state_size =
> this could be guarded by CONFIG_STM

This may be the issue.

https://review.coreboot.org/c/coreboot/+/38322/1/src/cpu/x86/smm/smm_stub.S 
File src/cpu/x86/smm/smm_stub.S:

https://review.coreboot.org/c/coreboot/+/38322/1/src/cpu/x86/smm/smm_stub.S@... 
PS1, Line 47: num_cpus:
> these fields could be guarded

These fields have to correspond with smm_runtime.  So, if a guard is placed here, smm runtime needs it also.