Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36777 )
Change subject: cpu/x86/lapic: Support x86_64 and clean up code ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG@7 PS1, Line 7: cpu/x86/lapic: Cleanup code
Too generic. Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG@7 PS1, Line 7: Cleanup
Clean up
Done
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG@9 PS1, Line 9: interrupts : in qemu
Do they need to be 32-bit?
Done
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG@14 PS1, Line 14: again
Did it ever work before with x86_64?
Yes, I had it working and it broke, but I can't say when or why, as the x86_64 topic is being worked on for nearly one year.
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG@14 PS1, Line 14: working
work
Done