Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35086 )
Change subject: devicetree: Remove weak declarations for ops
......................................................................
Patch Set 5:
Patch Set 5:
Need some advice with 'chip drivers/generic/generic'. CB:28796 added actual chip_operations but the path was already taken for (dummy) SPD and MAC eeprom devices.
My guess is we'll have to carve out a new path to make everything work. I *think* just a handful of devicetree.cb entries are using the ops (from a quick glance). We can just move some stuff around and should be good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb783e2f733d5c65c615e5c1879e3e4c7a83e049
Gerrit-Change-Number: 35086
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 07 Oct 2019 15:16:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment