Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 101: PLTRST
We can move it to deep, I thought the SPK Enable reset on PLTRST should not break any functionality […]
How does this behave with S3? Does it result in any unwanted issues on resume in OS? I know S3 is not POR, but curious about the behavior.
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36,
I checked and see a mean around 300Khz, but not exceeding 400Khz
We might need some more tuning to bring this close to 400. I think it would be good to raise a bug anyways since this has to be done for all I2C buses.