Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30421 )
Change subject: Makefile.inc: Create a default SMMSTORE region ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/30421/5/Makefile.inc File Makefile.inc:
https://review.coreboot.org/#/c/30421/5/Makefile.inc@893 PS5, Line 893: FMAP_SMMSTORE_SIZE := 0
this means that we create a 0-sized fmap region in this case, right?
No. There won't be an entry since FMAP_SMMSTORE_ENTRY is empty and ##SMMSTORE_ENTRY## gets replaced by this empty line after which there are no BASE/SIZE values to be replaced in the default fmap.
Btw I think this does not scale well at all. We now have over 150 lines of Makefile code to generate a very basic fmap, that is very error prone. This won't scale if we want more advanced FMAP layouts to be generated by default. Time to have a separate tool to generate useful fmap layouts?