Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44253 )
Change subject: gpio: Pull down HiZ pins after reading tristate GPIO strapping ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
I don't have +2, but this looks fine to me. I assume coreboot folks know what the rules are for comment style, but it seemed weird to me that it didn't match the rest of the function.
https://review.coreboot.org/c/coreboot/+/44253/1/src/lib/gpio.c File src/lib/gpio.c:
https://review.coreboot.org/c/coreboot/+/44253/1/src/lib/gpio.c@117 PS1, Line 117: /* Disable pull to avoid wasting power. For HiZ we leave the : pull-down enabled, since letting them float freely back and : forth may waste power in the SoC's GPIO input logic. */ Different comment style matter?