Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39839 )
Change subject: lp/drivers/usb: Add quirk for QEMU XHCI root hub ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/generic_hub.c:
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... PS2, Line 222: hub_status_changed Alternatively to the whole quirk infrastructure, could we just not set the pointer?
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/quirks.c:
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... PS2, Line 62: #if CONFIG(LP_USB_PCI) Can we leave this to the linker?