Matthew Garrett has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32549 )
Change subject: SKL: Add ACPI brightness control ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32549/3/src/soc/intel/skylake/graphics.c File src/soc/intel/skylake/graphics.c:
https://review.coreboot.org/#/c/32549/3/src/soc/intel/skylake/graphics.c@129 PS3, Line 129: if (!dev)
It would be better if you use !dev || !dev->enabled here
Done