Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38748 )
Change subject: soc/intel/skylake: Control fixed IO decode from devicetree ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38748/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38748/4//COMMIT_MSG@7 PS4, Line 7: io
IO
Done
https://review.coreboot.org/c/coreboot/+/38748/4//COMMIT_MSG@7 PS4, Line 7: device tree
devicetree
Done
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/lpc_lib.h:
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/common/block/... PS2, Line 75: the current
Well, `lpc_set_fixed_io_ranges` sets the decode ranges according to its parameters, so it does not s […]
Done
https://review.coreboot.org/c/coreboot/+/38748/4/src/soc/intel/common/block/... File src/soc/intel/common/block/lpc/lpc_lib.c:
https://review.coreboot.org/c/coreboot/+/38748/4/src/soc/intel/common/block/... PS4, Line 45: lpc_set_fixed_io_ranges
Can we rename this to `lpc_set_fixed_io_decode` for consistency? It touches the same register as `lp […]
Done