Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )
Change subject: mb/google/dedede: Add SD card support ......................................................................
Patch Set 26:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39237/26/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39237/26/src/mainboard/google/deded... PS26, Line 258: device pci 14.5 on end # SDCard Nit: an extra space to align with the rest of the 'end' below.
https://review.coreboot.org/c/coreboot/+/39237/25/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39237/25/src/mainboard/google/deded... PS25, Line 272: NATIVE
Thanks Aamir! Can you please add the reference to the EDS section as well in the comment here?
I remember seeing the CLK Termination to Native in the EDS Vol1. Glad to see that the clock tuning errors are addressed with the termination.
https://review.coreboot.org/c/coreboot/+/39237/26/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39237/26/src/mainboard/google/deded... PS26, Line 387: DEEP Should this pad reset config align with the Card detect GPIO GPP_G5 i.e. PLTRST