Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32564 )
Change subject: crossgcc: Upgrade GCC to 9.2.0
......................................................................
Patch Set 34:
(1 comment)
Patch Set 31:
This hasn't been tested on the Google EC codebase yet, so wait to merge it until it has.
What sort of test would that look like? I tried compiling the EC boards with this patch yesterday, and I didn't see any problems compared to GCC 8. (Granted this was outside of a cros chroot though.) GCC 9 has several improvements and bug fixes for LTO support, so I'd like to help get this merged.
https://review.coreboot.org/c/coreboot/+/32564/21/util/xcompile/xcompile
File util/xcompile/xcompile:
https://review.coreboot.org/c/coreboot/+/32564/21/util/xcompile/xcompile@230
PS21, Line 230: GCC_CFLAGS_${TARCH}+=-Wlogical-op -Wno-address-of-packed-member
Yes for sure. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32564
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6f65548764654ae5539ac3c835853ea2fa1c5e0
Gerrit-Change-Number: 32564
Gerrit-PatchSet: 34
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Tue, 25 Feb 2020 19:29:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment