Attention is currently required from: Ravi kumar, Sudheer Amrabadi, mturney mturney.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56642 )
Change subject: google/herobrine: configure gpio to detect board ID.
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/herobrine/boardid.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127224):
https://review.coreboot.org/c/coreboot/+/56642/comment/a48994bb_d31ff53f
PS6, Line 23: (id == QCOM_SC7280_SKU3) || (id == QCOM_SC7280_SKU4))
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56642
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6de2a7e7b11ecce8325e0fd44dc7221d73729390
Gerrit-Change-Number: 56642
Gerrit-PatchSet: 6
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Wed, 01 Sep 2021 11:57:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment