Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30902 )
Change subject: mistral: qcs405: Updated the layout info as in Gale ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/#/c/30902/5/src/mainboard/google/mistral/chromeo... File src/mainboard/google/mistral/chromeos.fmd:
https://review.coreboot.org/#/c/30902/5/src/mainboard/google/mistral/chromeo... PS5, Line 7: GBB@0x301000 0xdef00
Ok. So this we copied the layout same as in Gale, as per the feedback on buganiser. […]
I think the VPD is big enough at 128K, I'd add it to COREBOOT - but only after we moved everybody to ES1.1 hardware so we can more freely move FMAP (without having to adapt XBL)
https://review.coreboot.org/#/c/30902/5/src/mainboard/google/mistral/chromeo... PS5, Line 20: RW_GPT@0x560000 0x20000 {
In fact, we took this layout from Gale chromeos.fmd after we are asked to start using that. […]
If it's not needed for mistral, let's drop it here. Starting out from Gale was probably useful, but we don't have to keep everything around "just because". Cheza may be - generally speaking - the better template because it's more recent and better maintained than Gale that we merely keep on life support.