[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Reorganize memory initialization support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39865 )

Change subject: soc/intel/tigerlake: Reorganize memory initialization support
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39865/2/src/soc/intel/tigerlake/mem... 
File src/soc/intel/tigerlake/meminit_tgl.c:

https://review.coreboot.org/c/coreboot/+/39865/2/src/soc/intel/tigerlake/mem... 
PS2, Line 22: static uint8_t get_dimm_cfg(uintptr_t dimm0, uintptr_t dimm1)
> Disable both channels? Or disable both dimms of same channel?

If this is for DDR4 SODIMM, then you will have to ensure that:
a) half_populated is set to true.
b) addr_dimm0 and addr_dimm1 are initialized only for the DIMMs that are populated: https://review.coreboot.org/c/coreboot/+/39866/4/src/soc/intel/tigerlake/inc...

https://review.coreboot.org/c/coreboot/+/39865/2/src/soc/intel/tigerlake/mem... 
PS2, Line 40: Reserved9
> Bug here: b/152000235

Done