Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
huh? ofc you shouldn't do that. see Angel's example which boils down to a few lines Kconfig in your case
adding 2 new baseboards only to select the SoC, just to keep everything in Kconfig seems like a tortured exercise just to adhere to an arbitrary guideline, but I will relent and adjust
it's a ~10 LOC change; I don't see the "tortured exercise" ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4764f2c1243ea49bd08e0735865cc3cb7a66441f
Gerrit-Change-Number: 47051
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Sun, 01 Nov 2020 10:17:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment