Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39690 )
Change subject: mb/ocp/tiogapass: Configure IPMI FRB2 watchdog timer via VPD variables in romstage ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39690/15/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/romstage.c:
https://review.coreboot.org/c/coreboot/+/39690/15/src/mainboard/ocp/tiogapas... PS15, Line 75: if (vpd_get_bool(FRB2_TIMER, VPD_RW, &enable)) { : if (!enable) { : printk(BIOS_DEBUG, "Disable FRB2 timer\n"); : ipmi_stop_bmc_wdt(BMC_KCS_BASE); : return; : } : } so the strategy is to enable timer even if we are not sure it was meant to be enabled? Could you please elaborate why do we do it in this specific way? I personally feel it is rather not turn something on that is potentially destructive