build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43959 )
Change subject: soc/mediatek/mt8192: Add gpio driver
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43959/4/src/soc/mediatek/mt8192/inc...
File src/soc/mediatek/mt8192/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/43959/4/src/soc/mediatek/mt8192/inc...
PS4, Line 16: #define PIN(id, name, flag, bit, base, offset, \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43959
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b230aebc9eb4ca1bbf444c3a2f30159d707f37b
Gerrit-Change-Number: 43959
Gerrit-PatchSet: 4
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Po Xu
jg_poxu@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Aug 2020 06:07:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment