Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33193 )
Change subject: soc/intel/{cml, whl}: Add option to skip HECI function disable in SMM
......................................................................
Patch Set 1:
(2 comments)
Patch Set 1:
(2 comments)
Can’t this be checked by the code, if the UPD is provided?
https://review.coreboot.org/#/c/33193/1/src/soc/intel/cannonlake/Kconfig
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/33193/1/src/soc/intel/cannonlake/Kconfig@30
PS1, Line 30: CHROMEOS
Is this really the right check? […]
Hi Duncan, I have tested this code further on hatch CML and WHL, i don't see any issue there as well. My earlier test was on RVP
https://review.coreboot.org/#/c/33193/1/src/soc/intel/common/block/smm/Kconf...
File src/soc/intel/common/block/smm/Kconfig:
https://review.coreboot.org/#/c/33193/1/src/soc/intel/common/block/smm/Kconf...
PS1, Line 32: This Kconfig will help to skip HECI function disable using
: SMM mode. User to only select this option if FSP provide
: dedicated UPD to perform HECI function disable.
Skip HECI function disable using SMM. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33193
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3b064f3c32877235916f966a01beb525156d188
Gerrit-Change-Number: 33193
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Jun 2019 07:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment