John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49051 )
Change subject: ec/google/chromeec: Add RFWU into EC RAM for Retimer firmware update
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49051/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/49051/1//COMMIT_MSG@21
PS1, Line 21: verified RFWU entry from ACPI DSDT ERAM
How can this be verified?
Just acpidump, acpixtract, iasl and then review the dsdt.dsl EC's ERAM field, where RFWU is defined at offset 0x14.
https://review.coreboot.org/c/coreboot/+/49051/1//COMMIT_MSG@21
PS1, Line 21: kerenl
kernel (which version)
any version kernel.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ba04c6357b6fd0cc33ffce33e7e430539bace79
Gerrit-Change-Number: 49051
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Jan 2021 17:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment