Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48526 )
Change subject: util: Modify LPDDR4 spd_tools to generate SPDs for ADL boards
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3: Code-Review+2
ohhh no you should be very frightened of me giving a +2 go anything written in Go, I've never written a line of it before đ I'll have to take some time to look over this codebase đ
hahah.. i wanted to make sure you got a chance to look at this (in case you had other ideas of handling this :))
Just hoping we don't mysteriously run into compatibility issues between the two later... đ
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48526
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4964ec28d74ab36c6b6f2e9dce6c923d1df95c84
Gerrit-Change-Number: 48526
Gerrit-PatchSet: 3
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Dec 2020 22:10:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment