build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35156 )
Change subject: nb/intel/x4x: Do cosmetic fixes ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35156/2/src/northbridge/intel/x4x/r... File src/northbridge/intel/x4x/raminit_ddr23.c:
https://review.coreboot.org/c/coreboot/+/35156/2/src/northbridge/intel/x4x/r... PS2, Line 1320: if (s->spd_type == DDR3 && (r & 1) && s->dimms[ch * 2 + (r >> 1)].mirrored) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35156/2/src/northbridge/intel/x4x/x... File src/northbridge/intel/x4x/x4x.h:
https://review.coreboot.org/c/coreboot/+/35156/2/src/northbridge/intel/x4x/x... PS2, Line 189: #define IF_DIMM_POPULATED(dimms, idx) if (DIMM_IS_POPULATED(dimms, idx)) Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects