View Change

2 comments:

• File src/northbridge/intel/x4x/raminit_ddr23.c:

  • Patch Set #2, Line 1320: if (s->spd_type == DDR3 && (r & 1) && s->dimms[ch * 2 + (r >> 1)].mirrored) {

    braces {} are not necessary for single statement blocks

• File src/northbridge/intel/x4x/x4x.h:

  • Patch Set #2, Line 189: #define IF_DIMM_POPULATED(dimms, idx) if (DIMM_IS_POPULATED(dimms, idx))

    Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects

To view, visit change 35156. To unsubscribe, or for help writing mail filters, visit settings.