Attention is currently required from: Martin Roth, Chris Wang. Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52650 )
Change subject: mb/google/guybrush: Add STAPM values to overridetree ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52650/comment/0b2e7e26_9eb8b420 PS1, Line 38: register "slow_ppt_limit_mW" = "25000" I don't see a system_config=2. Do we need it?
https://review.coreboot.org/c/coreboot/+/52650/comment/7c1f5917_ba4ab6f9 PS1, Line 40: register "slow_ppt_time_constant_s" = "5" I remember hearing that we need to set at 9, but we might want this higher longterm. The spec says 5. What's the right value?