Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39731 )
Change subject: drivers/intel/gma/acpi: Provide default definition for displays
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39731/2/src/mainboard/samsung/stump...
File src/mainboard/samsung/stumpy/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39731/2/src/mainboard/samsung/stump...
PS2, Line 2: # IGD Displays
: register "gfx" = "GMA_DEFAULT_PANEL"
stumpy is a Chromebox, it doesn't have an integrated panel
there's probably quite a few boards in here without integrated displays, let's remove them all in a subsequent commit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39731
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d853c3b8250a2c7b2d1a91985a555e4b17ad76c
Gerrit-Change-Number: 39731
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 27 Mar 2020 20:37:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment