[coreboot-gerrit] Patch set updated for coreboot: 1023f8a vendorcode/amd/agesa: Logic typo in GfxPowerPlayLocateTdp

[Edward O'Callaghan]

Edward O'Callaghan ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5752

-gerrit

commit 1023f8a8ae87362f6ea2918f2590db0c82543719
Author: Edward O'Callaghan 
Date:   Thu May 15 19:37:24 2014 +1000

vendorcode/amd/agesa: Logic typo in GfxPowerPlayLocateTdp

The function GfxPowerPlayLocateTdp() sets MinDeltaSclk to a maximum
    sentinel value and checks DeltaSclk in a loop to minimize MinDeltaSclk.
    However, MinDeltaSclk incorrectly self-assigns.

Change-Id: Id01c792057681516bba411adec268769a3549aa8
    Signed-off-by: Edward O'Callaghan 
---
 .../f12/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c |  2 +-
 .../f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c | 12 ++++++------
 .../Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c     |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/vendorcode/amd/agesa/f12/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c b/src/vendorcode/amd/agesa/f12/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c
index 6642c8a..7ecb6fa 100644
--- a/src/vendorcode/amd/agesa/f12/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c
+++ b/src/vendorcode/amd/agesa/f12/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c
@@ -211,7 +211,7 @@ GfxPowerPlayLocateTdp (
       DpmSclk = GfxFmCalculateClock (PpFuses->SclkDpmDid[Index], StdHeader);
       DeltaSclk = (DpmSclk > Sclk) ? (DpmSclk - Sclk) : (Sclk - DpmSclk);
       if (DeltaSclk < MinDeltaSclk) {
-        MinDeltaSclk = MinDeltaSclk;
+        MinDeltaSclk = DeltaSclk;
         DpmIndex = Index;
       }
     }
diff --git a/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c b/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c
index feb6123..5f06eb6 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c
@@ -17,7 +17,7 @@
  *
  * Copyright (c) 2011, Advanced Micro Devices, Inc.
  * All rights reserved.
- * 
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *     * Redistributions of source code must retain the above copyright
@@ -25,10 +25,10 @@
  *     * Redistributions in binary form must reproduce the above copyright
  *       notice, this list of conditions and the following disclaimer in the
  *       documentation and/or other materials provided with the distribution.
- *     * Neither the name of Advanced Micro Devices, Inc. nor the names of 
- *       its contributors may be used to endorse or promote products derived 
+ *     * Neither the name of Advanced Micro Devices, Inc. nor the names of
+ *       its contributors may be used to endorse or promote products derived
  *       from this software without specific prior written permission.
- * 
+ *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
  * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
@@ -39,7 +39,7 @@
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- * 
+ *
  * ***************************************************************************
  *
  */
@@ -204,7 +204,7 @@ GfxPowerPlayLocateTdp (
       DpmSclk = GfxFmCalculateClock (PpFuses->SclkDpmDid[Index], StdHeader);
       DeltaSclk = (DpmSclk > Sclk) ? (DpmSclk - Sclk) : (Sclk - DpmSclk);
       if (DeltaSclk < MinDeltaSclk) {
-        MinDeltaSclk = MinDeltaSclk;
+        MinDeltaSclk = DeltaSclk;
         DpmIndex = Index;
       }
     }
diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c b/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c
index 0c3e7a1..1bbb397 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbGfxInitLibV1/GfxPowerPlayTable.c
@@ -147,7 +147,7 @@ GfxPowerPlayLocateTdp (
       DpmSclk = GfxFmCalculateClock (PpFuses->SclkDpmDid[Index], StdHeader);
       DeltaSclk = (DpmSclk > Sclk) ? (DpmSclk - Sclk) : (Sclk - DpmSclk);
       if (DeltaSclk < MinDeltaSclk) {
-        MinDeltaSclk = MinDeltaSclk;
+        MinDeltaSclk = DeltaSclk;
         DpmIndex = Index;
       }
     }