[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Create trondo variant

[Nick Vaccaro (Code Review)]

Attention is currently required from: David Wu.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40686 )

Change subject: mb/google/volteer: Create trondo variant
......................................................................

Patch Set 4:

(3 comments)

File src/mainboard/google/volteer/variants/trondo/gpio.c:

https://review.coreboot.org/c/coreboot/+/40686/comment/409ec518_9cedf224 
PS4, Line 13: variant_base_gpio_table
This will cause NO gpio's to get configured.  Is that what you intended to do?

You only want to define this IF you want to override all base gpio's set by baseboard's gpio.c.

https://review.coreboot.org/c/coreboot/+/40686/comment/121b7890_17d3d5c7 
PS4, Line 24: variant_early_gpio_table
Defining this without having any early gpios defined will bypass the setting of the early gpio's in baseboard's gpio.c, resulting in NO early gpios defined or configured.

Is that what you intended to do?  If not, early_gpio_table[] and variant_early_gpio_table() should be removed from this file.

https://review.coreboot.org/c/coreboot/+/40686/comment/59fef9c0_d9ec5c48 
PS4, Line 33: variant_cros_gpios
Same concept here.  This will make it so that NO cros_gpios are defined.