Attention is currently required from: Felix Singer, Name of user not set #1003506, Martin Roth, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52594 )
Change subject: mainboard: Add Synology DS918+ ......................................................................
Patch Set 2:
(62 comments)
File src/mainboard/synology/ds918plus/gpio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/9bb500fe_46bdac3e PS2, Line 49: PAD_CFG_GPI_APIC_IOS(GPIO_33, DN_20K, DEEP, EDGE_SINGLE, NONE, IGNORE, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/2e8e82bf_c8d4bc04 PS2, Line 54: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/f71adfdb_cb14fb09 PS2, Line 55: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/83e40777_15871b38 PS2, Line 56: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_40, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_RTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/b8eefe0e_f6faff22 PS2, Line 57: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_41, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_CTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/9ab728bf_256757ab PS2, Line 58: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_42, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART1_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/7799c074_eb92f90c PS2, Line 59: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, UP_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/cbdb6c5f_3cd92d11 PS2, Line 60: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_44, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART1_RTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/2dab710a_aa03c035 PS2, Line 61: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_45, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_CTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/e7ee2de9_5b1396e9 PS2, Line 87: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(CNV_BRI_DT, DN_20K, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/7cf09235_14aa002d PS2, Line 88: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(CNV_BRI_RSP, DN_20K, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/a5c94ea0_5f0d8050 PS2, Line 104: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_193, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/f9f15d61_7d32fe1e PS2, Line 105: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_194, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/4c365b1b_18da9fc3 PS2, Line 106: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_195, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/aea14757_66bea029 PS2, Line 116: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_FS0, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/f1235f5e_2bcca2c1 PS2, Line 117: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_FS1, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/efac346d_30af5180 PS2, Line 119: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_RXD, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/80ef617f_f35a161a PS2, Line 120: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_TXD, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/92084d03_6af26e71 PS2, Line 121: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_CLK, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/b2d066e2_0b0bd84d PS2, Line 123: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMIC_RESET_B, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/63ac4536_ffc0d659 PS2, Line 128: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMIC_STDBY, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/ba1dac86_0797d5ac PS2, Line 139: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_81, DN_20K, DEEP, NF2, TxDRxE, ENPD), /* AVS_I2C4_SDI */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/f950fb37_c80d05ec PS2, Line 141: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_83, DN_20K, DEEP, NF1, TxDRxE, ENPD), /* AVS_DMIC_DATA_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/718cf2f9_314acaac PS2, Line 149: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_91, DN_20K, DEEP, NF1, TxDRxE, ENPD), /* AVS_I2S3_SDI */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/11733c9e_ed7d03b2 PS2, Line 159: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_104, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_CLK */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/58c201cc_b5b42061 PS2, Line 160: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_105, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_FS0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/48c6348b_bb25bb3c PS2, Line 161: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_106, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_FS1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/708e7610_85b255d0 PS2, Line 162: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_109, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/87dd3971_05439506 PS2, Line 163: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_110, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/1fb118f9_c3a58fa0 PS2, Line 179: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_124, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C0_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/102c563b_7db4cfdf PS2, Line 180: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_125, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C0_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/63d97540_b4353c16 PS2, Line 181: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_126, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C1_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/2e81c8a0_bd344096 PS2, Line 182: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_127, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C1_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/067f1e7d_d3a58774 PS2, Line 183: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_128, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C2_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/823ca99f_98fc7a10 PS2, Line 184: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_129, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C2_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/b5a2ed20_16a115e9 PS2, Line 185: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_130, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C3_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/6fb8a045_203a1ac1 PS2, Line 186: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_131, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C3_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/83e06937_a67ee686 PS2, Line 187: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_132, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C4_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/69b46e2b_c8d5730c PS2, Line 188: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_133, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C4_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/c2abb4a4_523420b6 PS2, Line 189: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_134, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C0_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/20d0ff97_4ee86ceb PS2, Line 190: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_135, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C0_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/bd3ee635_589f47e8 PS2, Line 191: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_136, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C1_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/a0c4c4e8_95b85843 PS2, Line 192: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_137, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C1_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/a3faffd7_fc34ba0d PS2, Line 193: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_138, UP_1K, DEEP, NF1, Tx0RxDCRx0, ENPU), /* LPSS_I2C7_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/ca16b653_83f14016 PS2, Line 194: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_139, UP_1K, DEEP, NF1, Tx0RxDCRx0, ENPU), /* LPSS_I2C7_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/79bb4585_0aea4dc1 PS2, Line 205: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ0_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/74ea0e4f_fc362bbc PS2, Line 206: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_210, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ1_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/4ba251c4_3bd02933 PS2, Line 207: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_211, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ2_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/6e88afb1_b2153bfc PS2, Line 208: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_212, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ3_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/e8c6113f_5ecba6e6 PS2, Line 218: PAD_CFG_NF_IOSTANDBY_IGNORE(PMU_RESETBUTTON_B, NONE, DEEP, NF1), /* PMU_RSTBTN_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/86731349_e3a4b978 PS2, Line 223: PAD_CFG_GPO_IOSSTATE_IOSTERM(PMU_WAKE_B, 1, DEEP, UP_20K, IGNORE, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/f78b0acb_3c9551aa PS2, Line 266: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_CLKOUT1, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_CLKOUT1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/ee2edbec_c463ebde PS2, Line 267: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD0, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/8d5d47ea_09f22f63 PS2, Line 268: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD1, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/c20cf67c_a307fa3d PS2, Line 269: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD2, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/18be86e9_8b94c013 PS2, Line 270: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD3, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/883af2d8_45826d5f PS2, Line 272: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_FRAMEB, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_FRAMEB */ line over 96 characters
File src/mainboard/synology/ds918plus/gpio_early.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/7f930f4b_649f2969 PS2, Line 42: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_210, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ1_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/8bac0142_c4723849 PS2, Line 60: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/2d65fb4f_a1145ef0 PS2, Line 61: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/5ed8100b_bc889441 PS2, Line 62: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_42, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART1_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117645): https://review.coreboot.org/c/coreboot/+/52594/comment/7031fbbd_b9cfbcec PS2, Line 63: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, UP_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_TXD */ line over 96 characters