Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45416 )
Change subject: soc/intel/common/block/chip: Refactor chip_get_common_soc_structure() ......................................................................
soc/intel/common/block/chip: Refactor chip_get_common_soc_structure()
Found-by: Klocwork, Pointer soc_config is used uninitialized.
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I7e2aa4ef23a68a2ec2ba9d55cf890a7f81e3e278 --- M src/soc/intel/common/block/chip/chip.c 1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/45416/1
diff --git a/src/soc/intel/common/block/chip/chip.c b/src/soc/intel/common/block/chip/chip.c index 09f2c47..a9bfb17 100644 --- a/src/soc/intel/common/block/chip/chip.c +++ b/src/soc/intel/common/block/chip/chip.c @@ -5,11 +5,5 @@
const struct soc_intel_common_config *chip_get_common_soc_structure(void) { - const struct soc_intel_common_config *soc_config; - const config_t *config; - - config = config_of_soc(); - soc_config = &config->common_soc_config; - - return soc_config; + return &config_of_soc()->common_soc_config; }