[coreboot-gerrit] Change in ...coreboot[master]: Revert "soc/intel/cannonlake: Enable coreboot MP PPI service for WHL/...

[Lijian Zhao (Code Review)]

Hello Aaron Durbin, Patrick Rudolph, Nathaniel L Desimone, Subrata Banik, Aamir Bohra, Maulik V Vaghela, Duncan Laurie, Rizwan Qureshi, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/32391

to review the following change.

Change subject: Revert "soc/intel/cannonlake: Enable coreboot MP PPI service for WHL/CML"
......................................................................

Revert "soc/intel/cannonlake: Enable coreboot MP PPI service for WHL/CML"

This reverts commit 41dad286d846819242a84fc65faed2bbb35845ac. The change will make s0ix fail on Sarien/Arcada Platform.

Change-Id: I169bc6f41fba82fcf515267e8e1d08aa5ee2dce4
---
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/cannonlake/fsp_params.c
M src/soc/intel/cannonlake/romstage/fsp_params.c
3 files changed, 1 insertion(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/32391/1

diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig
index 14404f7..c30b562 100644
--- a/src/soc/intel/cannonlake/Kconfig
+++ b/src/soc/intel/cannonlake/Kconfig
@@ -27,8 +27,6 @@
    bool
    default n
    select SOC_INTEL_COMMON_CANNONLAKE_BASE
-	select FSP_PEIM_TO_PEIM_INTERFACE
-	select USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
    help
      Intel Whiskeylake support

@@ -36,12 +34,6 @@
    bool
    default n
    select SOC_INTEL_COMMON_CANNONLAKE_BASE
-	# TODO:
-	# Delete FSP_PEIM_TO_PEIM_INTERFACE and
-	# USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI selection
-	# and select PLATFORM_USES_FSP2_1 once FSP support for CML is ready
-	select FSP_PEIM_TO_PEIM_INTERFACE
-	select USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
    help
      Intel Cometlake support

diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c
index 1fd42cd..b8dba18 100644
--- a/src/soc/intel/cannonlake/fsp_params.c
+++ b/src/soc/intel/cannonlake/fsp_params.c
@@ -18,9 +18,7 @@
 #include <device/device.h>
 #include <device/pci.h>
 #include <fsp/api.h>
-#include <fsp/ppi/mp_service_ppi.h>
 #include <fsp/util.h>
-#include <intelblocks/mp_init.h>
 #include <intelblocks/xdci.h>
 #include <soc/intel/common/vbt.h>
 #include <soc/pci_devs.h>
@@ -144,9 +142,6 @@
    	params->Usb3OverCurrentPin[i] = 0;
    }

-	if (CONFIG(USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI))
-		params->CpuMpPpi = (uintptr_t) mp_fill_ppi_services_data();
-
    mainboard_silicon_init_params(params);

/* Set PsysPmax if it is available from DT */
diff --git a/src/soc/intel/cannonlake/romstage/fsp_params.c b/src/soc/intel/cannonlake/romstage/fsp_params.c
index 4545f52..ffdcee4 100644
--- a/src/soc/intel/cannonlake/romstage/fsp_params.c
+++ b/src/soc/intel/cannonlake/romstage/fsp_params.c
@@ -68,10 +68,7 @@
    	m_cfg->VmxEnable = config->VmxEnable;

#if CONFIG(SOC_INTEL_COMMON_CANNONLAKE_BASE)
-	if (CONFIG(USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI))
-		m_cfg->SkipMpInit = 0;
-	else
-		m_cfg->SkipMpInit = !CONFIG_USE_INTEL_FSP_MP_INIT;
+	m_cfg->SkipMpInit = !CONFIG_USE_INTEL_FSP_MP_INIT;
 #endif

/* Set CpuRatio to match existing MSR value */