Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36840 )
Change subject: soc/intel/skylake: Clean-up report_cpu_info() function ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/c/coreboot/+/36840/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36840/4//COMMIT_MSG@9 PS4, Line 9: clean up
clean-up
Done
https://review.coreboot.org/c/coreboot/+/36840/4//COMMIT_MSG@7 PS4, Line 7: soc/intel/skylake: Clean up report_cpu_info() function : : This patch makes below clean up for report_cpu_info() function : 1. Replace cpu_string with cpu_not_found : 2. Assign default string "Platform info not available" to cpu_not_found string : 3. Add array out of bound check while skiping leading white space in cpu brand : string name
stale now?
Done
https://review.coreboot.org/c/coreboot/+/36840/4//COMMIT_MSG@14 PS4, Line 14:
It could be three commits next time?
Done
https://review.coreboot.org/c/coreboot/+/36840/4//COMMIT_MSG@15 PS4, Line 15: TEST=Able to build and boot soraka.
Isn’t a successful boot is worth mentioning?
Done
https://review.coreboot.org/c/coreboot/+/36840/4/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/36840/4/src/soc/intel/skylake/bootb... PS4, Line 168: struct cpuid_result;
unused?
Done
https://review.coreboot.org/c/coreboot/+/36840/4/src/soc/intel/skylake/bootb... PS4, Line 170: 50
49 should be enough.
Done