19 Feb
2020
19 Feb
'20
7:26 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38855 )
Change subject: mb/google/dedede: Add USB configuration ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38855/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/38855/2/src/mainboard/google/dedede... PS2, Line 25: UP_20K Are these the POR states for the pads?
--
To view, visit https://review.coreboot.org/c/coreboot/+/38855
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19f7563013c7d702d52b7f34a207a34abe308621
Gerrit-Change-Number: 38855
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aamir Bohra aamir.bohra@intel.com
Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 19 Feb 2020 06:26:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment