Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34882 )
Change subject: arch/x86: Move stack with CAR_GLOBAL_MIGRATION
......................................................................
Patch Set 19: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34882/19/src/soc/amd/picasso/Kconfi...
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/34882/19/src/soc/amd/picasso/Kconfi...
PS19, Line 89: DCACHE_BSP_STACK_SIZE
I believe this will disappear for Picasso, as it does not uses CAR. I'm not sure on the details, last I heard (though there was a plan to change it somewhat) Picasso uses "HIBRID_ROMSTAGE" replacing regular ROMSTAGE in that memory is already enabled in this stage. Memory is trained and enabled before Picasso exits reset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58d50c6f8f922c9e8664698d77836cac2c13b126
Gerrit-Change-Number: 34882
Gerrit-PatchSet: 19
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 26 Aug 2019 23:48:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment