[coreboot-gerrit] Change in coreboot[master]: soc/intel: Return ACPI_S4 as previous sleep state

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/64002 )

Change subject: soc/intel: Return ACPI_S4 as previous sleep state
......................................................................

soc/intel: Return ACPI_S4 as previous sleep state

pmc_prev_sleep_state() isn't handling the case where acpi_sleep_from_pm1()
returns ACPI_S4. Pass that value along so it can get set as a
prev_sleep_state. Without this, consumers see prev_sleep_state as 0
and always treat resume as a cold boot. With this, consumers can
correctly do behavior specific to S4 resume, like skipping the
disconnect IPC command to the PMC on Alderlake systems.

BUG=b:230031158
TEST=Resume from S4 on Primus4es

Signed-off-by: Evan Green 
Change-Id: I3fb3dc428a749db80293e51a04a2096514a7b689
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64002
Tested-by: build bot (Jenkins) 
Reviewed-by: Subrata Banik 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Eric Lai 
---
M src/soc/intel/common/block/pmc/pmclib.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved
  Subrata Banik: Looks good to me, approved
  Eric Lai: Looks good to me, approved

diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c
index a2e3e9e..a733920 100644
--- a/src/soc/intel/common/block/pmc/pmclib.c
+++ b/src/soc/intel/common/block/pmc/pmclib.c
@@ -399,6 +399,9 @@
    		if (CONFIG(HAVE_ACPI_RESUME))
    			prev_sleep_state = ACPI_S3;
    		break;
+		case ACPI_S4:
+			prev_sleep_state = ACPI_S4;
+			break;
    	case ACPI_S5:
    		prev_sleep_state = ACPI_S5;
    		break;

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.