Attention is currently required from: Arthur Heymans, Lean Sheng Tan, Paul Menzel, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82040?usp=email )
Change subject: libpayload: Save EAX and EBX only for multiboot payloads
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82040/comment/5aa39ec9_6411ce95 :
PS1, Line 12:
Why are they removed for non-multiboot things?
As you may have noticed, this CL is already V+1 after removing those variables from `non-multiboot`. This indicates that those variables are not being used in the case of `non-multiboot`. As a result, do we require any further justification to remove those unnecessary variables for `non-multiboot`?
marking this resolved based on no further response.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82040?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I98c2cd00206ee48eb0fc67edd9533032bcf3e5eb
Gerrit-Change-Number: 82040
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 02 May 2024 11:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment