build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33067 )
Change subject: soc/intel/common: Add SMBIOS type 131 fields ......................................................................
Patch Set 1:
(67 comments)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 534: union mkhi_header mkhi_hdr; Statements should start on a tabstop
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 744: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 750: void get_mebx_version(mebx_ver *mebx_version ) need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 750: void get_mebx_version(mebx_ver *mebx_version ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 758: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 765: pch_capabilities->device_id = pci_read_config16(PCH_DEV_LPC, PCI_DEVICE_ID); line over 80 characters
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 767: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 774: if (mkhi_get_fw_version(&version)) that open brace { should be on the previous line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 781: platf_cap->me_major_ver = 0; code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 781: platf_cap->me_major_ver = 0; please, no space before tabs
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 781: platf_cap->me_major_ver = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 790: if (mkhi_get_fwcaps(&fw_caps)) that open brace { should be on the previous line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 796: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 796: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 799: if (mkhi_get_platform_type(&platf_type)) that open brace { should be on the previous line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 801: switch (platf_type.brand) that open brace { should be on the previous line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 819: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 826: if (mkhi_get_fw_fea_state(&fwcaps)) that open brace { should be on the previous line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 845: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 856: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 861: if (cpu_feature_flag & CPUID_VMX) that open brace { should be on the previous line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 876: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 878: void generate_type131_data(me_smbios_info *me_info, struct smbios_type131 *type131) line over 80 characters
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 883: u32 platf_cap[3] = {0,0,0}, nwk_dev_lan[3] = {0,0,0}; space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 883: u32 platf_cap[3] = {0,0,0}, nwk_dev_lan[3] = {0,0,0}; space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 883: u32 platf_cap[3] = {0,0,0}, nwk_dev_lan[3] = {0,0,0}; space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 883: u32 platf_cap[3] = {0,0,0}, nwk_dev_lan[3] = {0,0,0}; space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 884: int i,j; space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 915: platf_cap[0] |= (pf_cap.me_enabled) ? 1: 0; spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 925: for (i=0; i < 3; i++) spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 941: for (j=0; j < 3; j++) spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 942: memcpy(&type131->network_device_lan[j],&nwk_dev_lan[j],4); space required after that ',' (ctx:VxO)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 942: memcpy(&type131->network_device_lan[j],&nwk_dev_lan[j],4); space required before that '&' (ctx:OxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 942: memcpy(&type131->network_device_lan[j],&nwk_dev_lan[j],4); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 952: memcpy(&type131->structure_id, "vPro",4); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 956: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 984: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/cse/cse.c... PS1, Line 989: static int smbios_write_type131_info(struct device *dev, int *handle, unsigned long *current) line over 80 characters
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 58: }__packed cpu_cap; space required after that close brace '}'
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 66: }__packed pch_cap; space required after that close brace '}'
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 81: }__packed me_cap; space required after that close brace '}'
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 104: uint32_t reserved_2 : 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 104: uint32_t reserved_2 : 1; please, no space before tabs
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 104: uint32_t reserved_2 : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 108: uint32_t reserve_4 : 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 108: uint32_t reserve_4 : 1; please, no space before tabs
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 108: uint32_t reserve_4 : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 111: uint32_t ipv6 : 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 111: uint32_t ipv6 : 1; please, no space before tabs
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 111: uint32_t ipv6 : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 113: uint32_t reserve_6 : 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 113: uint32_t reserve_6 : 1; please, no space before tabs
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 113: uint32_t reserve_6 : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 118: uint32_t reserve_8 : 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 118: uint32_t reserve_8 : 1; please, no space before tabs
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 118: uint32_t reserve_8 : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 121: }__packed mefwcaps_sku; space required after that close brace '}'
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 149: }__packed network_dev; space required after that close brace '}'
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 159: }__packed bios_cap; space required after that close brace '}'
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 166: }__packed mebx_ver; space required after that close brace '}'
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 193: }__packed me_smbios_info; space required after that close brace '}'
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 208: u8 eos[2]; code indent should use tabs where possible
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 208: u8 eos[2]; please, no space before tabs
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 208: u8 eos[2]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 209: }__packed ; space prohibited before semicolon
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 209: }__packed ; space required after that close brace '}'
https://review.coreboot.org/#/c/33067/1/src/soc/intel/common/block/include/i... PS1, Line 223: void generate_type131_data(me_smbios_info *me_info, struct smbios_type131 *type131); line over 80 characters