[coreboot-gerrit] Change in coreboot[master]: trogdor: Strappings_update_final3.1_second_thisistherealone.patch

[Julius Werner (Code Review)]

Hello Douglas Anderson, Philip Chen,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/45225

to review the following change.

Change subject: trogdor: Strappings_update_final3.1_second_thisistherealone.patch
......................................................................

trogdor: Strappings_update_final3.1_second_thisistherealone.patch

Apparently what I thought was lazor-rev2 is actually lazor-rev3 and
nobody is really sure what lazor-rev4 is going to be at this point or
how we proceed from there. What seems to be somewhat agreed upon is that
for now all Lazor revisions use the "old" GPIO mapping and it's not very
clear if that's ever going to change for Lazor, so let's take the
revision restriction out from Lazor for now.

Signed-off-by: Julius Werner 
Change-Id: I4939ccfd8464da6e72b5e01a58489b8c80f5b4df
---
M src/mainboard/google/trogdor/boardid.c
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/45225/1

diff --git a/src/mainboard/google/trogdor/boardid.c b/src/mainboard/google/trogdor/boardid.c
index f60dddbe..edde164 100644
--- a/src/mainboard/google/trogdor/boardid.c
+++ b/src/mainboard/google/trogdor/boardid.c
@@ -16,11 +16,12 @@
    return id;
 }

-/* Whether a revision was built before or after the great pin migration of August 2020. */
+/* Some boards/revisions use one GPIO mapping and others use another. There's no real rhyme or
+   reason to it. Don't try to think about it too much... */
 static bool use_old_pins(void)
 {
    return ((CONFIG(BOARD_GOOGLE_TROGDOR) && board_id() < 2) ||
-		(CONFIG(BOARD_GOOGLE_LAZOR) && board_id() < 3) ||
+		CONFIG(BOARD_GOOGLE_LAZOR) ||
    	(CONFIG(BOARD_GOOGLE_POMPOM) && board_id() < 1));
 }