Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25344 )
Change subject: ACPI: Add SPCR table
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/25344/6/src/arch/x86/acpi.c
File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/25344/6/src/arch/x86/acpi.c@1570
PS6, Line 1570: header
nit - this is preparing the whole table, not just the header.
I'll move the initial memset above the comment. The rest of this section is just the header.
https://review.coreboot.org/#/c/25344/6/src/arch/x86/acpi.c@1578
PS6, Line 1578: asl_compiler_revision = 0
= asl_revision;
I have to question that, even though it would match with the other tables. IASL isn't doing anything with this table. Why would we use the IASL version here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ff31da061c88a6f3e3cf76285f8ab78ee35509c
Gerrit-Change-Number: 25344
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Wed, 12 Jun 2019 16:00:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment