Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: nb/intel/sandybridge/raminit: Fix ECC scrub
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40721/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40721/3//COMMIT_MSG@12
PS3, Line 12: * Add ECC test code when DEBUG_RAM_SETUP is enabled
: * Move ECC scrubbing after set_scrambling_seed() to be able to observe
: what has been cleared.
: * ECC scrubbing must happen after dram_dimm_set_mapping()
: * Move method out of try_init_dram_ddr3()
: * Add comments with observations made while fixing the code
Please split up according to this list. Cosmetic changes should be
separate from functional ones. And functional changes should have
move specific commit messages.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40721
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9fcc236fbf73f51fe944c6dda5d22ba9d334ec7
Gerrit-Change-Number: 40721
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 May 2020 10:48:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment