Attention is currently required from: David Hendricks, Erik van den Bogaert, Frans Hendriks, Julius Werner, Matt DeVillier, Shuo Liu.
Hello David Hendricks, Erik van den Bogaert, Frans Hendriks, Julius Werner, Matt DeVillier, Shuo Liu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/87288?usp=email
to look at the new patch set (#2).
Change subject: treewide: Remove remainders of ROM_BASE ......................................................................
treewide: Remove remainders of ROM_BASE
commit a7eb390796ef ("mb/*/*/*.fmd: Start flash at 0") caused a build failure for all mainboards that generate their FMAP from the IFD (so intel only) instead of providing one themselves. Jenkins didn't catch that, because apparently all mainboards that have the IFD in the 3rdparty/blobs repository provide a custom FMAP. So there was no defconfig that jenkins tested that would come across this issue.
Signed-off-by: Maximilian Brune maximilian.brune@9elements.com Change-Id: Ia9852e8ef48148264d2d3f73eb667f3eb8b85005 --- M Makefile.mk M util/ifdtool/ifdtool.c 2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/87288/2