mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37069 )
Change subject: trogdor: add support for Bubs variant ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 11: select EC_GOOGLE_CHROMEEC if BOARD_GOOGLE_TROGDOR
These should all be […]
Done
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 18: select MAINBOARD_HAS_CHROMEOS
We'll also need a […]
Done
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 21: select EC_GOOGLE_CHROMEEC_SWITCHES if BOARD_GOOGLE_TROGDOR
Yeah, this made me compile.
Done
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 23: select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC if BOARD_GOOGLE_BUBS
You shouldn't need this since the depthcharge Kconfig already disables software sync.
Done
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 36: default 0x5
edit: 0x6 (see below)
Done
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 40: default 0xa
Sorry again, our schematics are basically loose unlabeled sheets of paper flying around the office a […]
Done
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/reset.c:
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo... PS1, Line 24: BOARD_GOOGLE_TROGDOR
In this case, we can instead add […]
Done