Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38512 )
Change subject: soc/intel/skylake: Only reserve TPM area for !CONFIG_TPM_CR50 device ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38512/3/src/soc/intel/skylake/acpi/... File src/soc/intel/skylake/acpi/systemagent.asl:
https://review.coreboot.org/c/coreboot/+/38512/3/src/soc/intel/skylake/acpi/... PS3, Line 185: #if !CONFIG(TPM_CR50)
This is highly irritating. By excluding one case when it is wrong, you make […]
basically this reservation is true for all TPM device using TIS interface using SOC bus like LPC, SPI and I2C as per TPM specification.
As Aaron explained google TPM doesn't even need those SOC mapped memory for its usage. Hence rather keeping
#if CONFIG(LPC_TPM) | CONFIG(SPI_TPM) || CONFIG(I2C_TPM), i have kept !TPM_CR50