Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36976 )
Change subject: vendorcode/amd/pi/Makefile.inc: remove -fno-zero-initialized-in-bss
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36976/1/src/vendorcode/amd/pi/Makef...
File src/vendorcode/amd/pi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36976/1/src/vendorcode/amd/pi/Makef...
PS1, Line 71: -fno-zero-initialized-in-bss
It looks like CAR is cleared indeed so that should be fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I088ac824f9b66387843ae5810fd2c75a8b16d9db
Gerrit-Change-Number: 36976
Gerrit-PatchSet: 1
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Wed, 20 Nov 2019 10:12:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment