Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34857 )
Change subject: mb/ocp/monolake: Add IPMI CMOS clear support ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34857/4/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/ipmi.h:
https://review.coreboot.org/c/coreboot/+/34857/4/src/mainboard/ocp/monolake/... PS4, Line 34: } __packed ipmi_oem_req_t; using packed struct and bitfields is discouraged due to portability concerns. Please add code to serialize/serialize the data.