Attention is currently required from: Furquan Shaikh, Martin Roth, Paul Fagerburg. Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50449
to look at the new patch set (#2).
Change subject: mb/google: order matters in mem_parts_used.txt ......................................................................
mb/google: order matters in mem_parts_used.txt
* Add comments to mem_parts_used.txt to point out that the order of the entries matters when assigning IDs, so always add a new part to the end of the file. * Update existing mem_parts_used.txt to add the same comment. * No updates to Zork variants, because they use an optional ID, so the order actually doesn't matter there.
BUG=b:175898902 TEST=create a new variant of dalboz, trembyle, volteer, waddledee, or waddledoo, and observe that mem_parts_used.txt has the new verbiage.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: Iffbd8e69a89b1b7c810c5d25c7a6148d459d8b02 --- M src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt M src/mainboard/google/dedede/variants/kracko/memory/mem_parts_used.txt M src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt M src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt M src/mainboard/google/dedede/variants/sasuke/memory/mem_parts_used.txt M src/mainboard/google/dedede/variants/sasukette/memory/mem_parts_used.txt M src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt M src/mainboard/google/volteer/variants/copano/memory/mem_parts_used.txt M src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt M util/mainboard/google/dalboz/template/spd/mem_parts_used.txt M util/mainboard/google/trembyle/template/spd/mem_parts_used.txt M util/mainboard/google/volteer/template/memory/mem_parts_used.txt M util/mainboard/google/waddledee/template/memory/mem_parts_used.txt M util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 14 files changed, 124 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/50449/2